Skip to content

Naming collision in Javascript ui registry (backend) to 2.2 #12945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

VladimirZaets
Copy link
Contributor

Added more strict elements selection.

Description

The JS is broken in next case: when new configurable attribute is created with the code name that is equal to "index" property of any uiComponent on the page.

Fixed Issues (if relevant)

  1. Naming collision in Javascript ui registry (backend) #12555: Naming collision in Javascript ui registry (backend)

Manual testing scenarios

Add a configurable attribute with attribute code set as "content", or any other name which exists as identifier on the product edit page (for example, "gallery", "review" ,"related").

Add it to the default attribute set

Edit a product.

  1. Move to magento admin panel.
  2. Move to Catalog -> Products page.
  3. Press "Add Product" button.
  4. Fill the required fields.
  5. Press "Create Configurations" button.
  6. Press "New Attribute" button that is in slide out panel.
  7. Fill the required fields and open the "Advanced Attribute Properties" panel.
  8. Set "content" value to "Attribute Code" field.
  9. Save the attribute.
  10. Select created attribute in the attributes list and press "next" button.
  11. Add some value and press next.
  12. Press "Generate Products" button.

Expected result: Products are generated.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets VladimirZaets changed the title MAGETWO-85179: Naming collision in Javascript ui registry (backend) #… Naming collision in Javascript ui registry (backend) to 2.2 Jan 2, 2018
@magento-engcom-team magento-engcom-team added mageconf Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 2, 2018
@ishakhsuvarov ishakhsuvarov self-assigned this Jan 2, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 2, 2018
@magento-team magento-team merged commit 64a1689 into magento:2.2-develop Jan 3, 2018
@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants